name: pre-commit run_id: commands[2] env HOME: /home/jenkins env LANG: C.UTF-8 env OLM_TIMER1: 3000 env OLM_TIMER2: 2000 env PATH: /w/workspace/transportpce-tox-verify-transportpce-master/.tox/pre-commit/bin:/opt/pyenv/bin:/tmp/venv-85nz/bin:/opt/pyenv/shims:/home/jenkins/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/opt/puppetlabs/bin env PIP_DISABLE_PIP_VERSION_CHECK: 1 env PYTHONHASHSEED: 3113691434 env PYTHONIOENCODING: utf-8 env TOX_ENV_DIR: /w/workspace/transportpce-tox-verify-transportpce-master/.tox/pre-commit env TOX_ENV_NAME: pre-commit env TOX_WORK_DIR: /w/workspace/transportpce-tox-verify-transportpce-master/.tox env VIRTUAL_ENV: /w/workspace/transportpce-tox-verify-transportpce-master/.tox/pre-commit metadata pid: 2495 cwd: /w/workspace/transportpce-tox-verify-transportpce-master/tests allow: /w/workspace/transportpce-tox-verify-transportpce-master/.tox/pre-commit/bin/*:sh:cpan:sudo:which:fixCIcentOS8reposMirrors.sh cmd: pre-commit run --all-files --show-diff-on-failure exit_code: 1 [WARNING] hook id `remove-tabs` uses deprecated stage names (commit) which will be removed in a future version. run: `pre-commit migrate-config` to automatically fix this. [WARNING] hook id `perltidy` uses deprecated stage names (commit) which will be removed in a future version. run: `pre-commit migrate-config` to automatically fix this. [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [WARNING] repo `https://github.com/pre-commit/pre-commit-hooks` uses deprecated stage names (commit, push) which will be removed in a future version. Hint: often `pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks` will fix this. if it does not -- consider reporting an issue to that repo. [INFO] Initializing environment for https://github.com/jorisroovers/gitlint. [INFO] Initializing environment for https://github.com/jorisroovers/gitlint:./gitlint-core[trusted-deps]. [INFO] Initializing environment for https://github.com/Lucas-C/pre-commit-hooks. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-autopep8. [INFO] Initializing environment for https://github.com/perltidy/perltidy. [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/Lucas-C/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/mirrors-autopep8. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/perltidy/perltidy. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing servicehandler/docs/Notifications.md Fixing tapi/docs/Notifications.md Tabs remover.............................................................Passed autopep8.................................................................Passed perltidy.................................................................Passed pre-commit hook(s) made changes. If you are seeing this message in CI, reproduce locally with: `pre-commit run --all-files`. To run `pre-commit` as part of git workflow, use `pre-commit install`. All changes made by hooks: diff --git a/servicehandler/docs/Notifications.md b/servicehandler/docs/Notifications.md index e89100529..9d227cb18 100644 --- a/servicehandler/docs/Notifications.md +++ b/servicehandler/docs/Notifications.md @@ -1,7 +1,7 @@ ## Notifications specifications -This file contains a brief overview of the different notificationListeners used in this module, -and their current use. +This file contains a brief overview of the different notificationListeners used in this module, +and their current use. #### NetworkModelNotificationHandler @@ -35,10 +35,10 @@ For `service-delete` this applies: * Listens to `DataTreeChanged` * if `DELETE` it do nothing -* if `DELETE` is combined with a service name that is beeing rerouted it will try to create a new service with the +* if `DELETE` is combined with a service name that is beeing rerouted it will try to create a new service with the service name from the notification. This is actually rerouting step 2. * if `WRITE` with a node that is taken out of service it forwards this as an NbiNotification. -Further if the `adminstrativeState` is `inService`, and there still exist a valid path, it will try to reroute the service +Further if the `adminstrativeState` is `inService`, and there still exist a valid path, it will try to reroute the service by adding it to the rerouting services and then delete the service. This will trigger a new `DataTreeChanged` notification that will start rerouting step 2 above. * if `WRITE` with a node that is taken into service, and the `administrativeState` is `ìnService` then it diff --git a/tapi/docs/Notifications.md b/tapi/docs/Notifications.md index 696ca3eb7..72a14da46 100644 --- a/tapi/docs/Notifications.md +++ b/tapi/docs/Notifications.md @@ -1,21 +1,21 @@ ## Notifications specifications This file contains a brief overview of the different notificationListeners used in this module, -and their current use. +and their current use. #### TapiNetworkNotificationHandler * Listens to the general `Notification` * if notificationType is `NOTIFICATIONTYPEATTRIBUTEVALUECHANGE` and targetObjectType is `TOPOLOGYOBJECTTYPENODEEDGEPOINT` -then it updates the connections and the connectivity services with regards to the changes. It then send an -* `NbiNotification`for each connectivityService updated. +then it updates the connections and the connectivity services with regards to the changes. It then send an +* `NbiNotification`for each connectivityService updated. #### TapiPceNotificationHandler * Listens to `ServicePathRpcresult` from the `pce` module. For a `path-computation-result` this applies: -* if this result is a successful , then it creates connections from the `ServicePathResult` +* if this result is a successful , then it creates connections from the `ServicePathResult` and stores it in the database. * if this result is pending, it will log a warning * if this result is failed, or unkown (default) then it will log an error. @@ -24,12 +24,12 @@ For a `cancel-resource-result` this applies: * If the result is failed, then it logs this as info. * If the result is pending, then it logs this as a warning. * If the result is unknown, then it logs an error -* If the result is successful, then it deletes the connections and connectivity associated with the servicename +* If the result is successful, then it deletes the connections and connectivity associated with the servicename in the result. #### TapiRendererNotificationHandler -* Listens to `RendererRpcResultSp` from the `renderer`module. +* Listens to `RendererRpcResultSp` from the `renderer`module. For a result of type `service-implementation-request` this applies: